tfaour
461beed04f
ESP-IDF locks ("holds") every pin armed as a GPIO deep-sleep wakeup
source across the sleep transition, and never releases it automatically
on wake -- confirmed against sleep_modes.c's
esp_sleep_gpio_wakeup_prepare_on_hp_periph_powerdown(), which calls
gpio_hold_en() with no corresponding gpio_hold_dis() anywhere in
ESP-IDF's own wake path. Left held, live gpio_get_level() reads stay
frozen at whatever level the pin had when sleep began (almost always
"not pressed"), which is indistinguishable from a real "not pressed"
reading and silently broke any live poll for a *new* press later in the
same awake session.
This never surfaced before the manage menu's escalation feature, since
every other button check either used the latched wakeup-status register
(unaffected by hold) or only polled once, early in boot, before any
sleep/wake cycle in that session. wait_for_button_press() is the first
code in this project to repeatedly poll a button live *after* having
just woken via that same pin -- exactly the case hold breaks. Fixed by
calling gpio_hold_dis() before gpio_config() in all three buttons' init
functions, not just manage's -- reset and next-photo have the same
latent issue in their own live-read fallback paths, just not yet
exercised the same way.
83 lines
2.8 KiB
C
83 lines
2.8 KiB
C
#include "driver/gpio.h"
|
|
#include "esp_log.h"
|
|
#include "esp_sleep.h"
|
|
|
|
#include "freertos/FreeRTOS.h"
|
|
#include "freertos/task.h"
|
|
|
|
#include "manage_button.h"
|
|
|
|
static const char *TAG = "manage_button";
|
|
|
|
#if CONFIG_FRAME_MANAGE_BUTTON_GPIO >= 0
|
|
|
|
#define MANAGE_BUTTON_GPIO ((gpio_num_t)CONFIG_FRAME_MANAGE_BUTTON_GPIO)
|
|
#define MANAGE_BUTTON_DEBOUNCE_MS 20
|
|
#define MANAGE_BUTTON_DEBOUNCE_CHECKS 3
|
|
|
|
void manage_button_init(void)
|
|
{
|
|
/* Every deep sleep with this pin armed as a wakeup source leaves it
|
|
* "held" (ESP-IDF locks the pin's pull/config across the sleep
|
|
* transition -- see esp_sleep_gpio_wakeup_prepare_on_hp_periph_powerdown()
|
|
* in sleep_modes.c) and, confirmed on hardware, never un-holds it on
|
|
* wake -- the application has to. Left held, live gpio_get_level()
|
|
* reads stay frozen at whatever level the pin had the moment sleep
|
|
* began (idle/unpressed, almost always), which looks identical to
|
|
* "not pressed" and silently breaks any live poll for a NEW press
|
|
* later in the same session -- exactly what the manage menu's
|
|
* escalation needs. Must run before gpio_config() below. */
|
|
gpio_hold_dis(MANAGE_BUTTON_GPIO);
|
|
|
|
gpio_config_t io_conf = {
|
|
.pin_bit_mask = 1ULL << MANAGE_BUTTON_GPIO,
|
|
.mode = GPIO_MODE_INPUT,
|
|
.pull_up_en = GPIO_PULLUP_ENABLE,
|
|
};
|
|
gpio_config(&io_conf);
|
|
|
|
/* See reset_button.c for why this API (not ext1) -- it manages the
|
|
* pull resistor across the sleep transition itself, so the pin
|
|
* doesn't float and wake the device spuriously. */
|
|
esp_sleep_enable_gpio_wakeup_on_hp_periph_powerdown(1ULL << MANAGE_BUTTON_GPIO, ESP_GPIO_WAKEUP_GPIO_LOW);
|
|
}
|
|
|
|
bool manage_button_check(void)
|
|
{
|
|
/* See next_button.c for why the latched wakeup status is checked
|
|
* first: a quick tap can release before a live gpio_get_level() call
|
|
* this far into boot would still see it held, even though it's what
|
|
* woke the device. */
|
|
if (esp_sleep_get_gpio_wakeup_status() & (1ULL << MANAGE_BUTTON_GPIO)) {
|
|
ESP_LOGI(TAG, "Manage button caused this wake, showing management QR");
|
|
return true;
|
|
}
|
|
|
|
if (gpio_get_level(MANAGE_BUTTON_GPIO) != 0) {
|
|
return false;
|
|
}
|
|
|
|
for (int i = 0; i < MANAGE_BUTTON_DEBOUNCE_CHECKS; i++) {
|
|
vTaskDelay(pdMS_TO_TICKS(MANAGE_BUTTON_DEBOUNCE_MS));
|
|
if (gpio_get_level(MANAGE_BUTTON_GPIO) != 0) {
|
|
return false; /* noise, not a real press */
|
|
}
|
|
}
|
|
|
|
ESP_LOGI(TAG, "Manage button held during power-on, showing management QR");
|
|
return true;
|
|
}
|
|
|
|
bool manage_button_is_pressed(void)
|
|
{
|
|
return gpio_get_level(MANAGE_BUTTON_GPIO) == 0;
|
|
}
|
|
|
|
#else
|
|
|
|
void manage_button_init(void) {}
|
|
bool manage_button_check(void) { return false; }
|
|
bool manage_button_is_pressed(void) { return false; }
|
|
|
|
#endif
|